[bug#33217] Modifying the commit message to gnu-Add-r-weights

Message ID CA+H0LRN=dGCGZPS85eah1=x7MAP6+y7HvR4Tdbw79q1aeC8Ptg@mail.gmail.com
State New
Headers show
Series
  • [bug#33217] Modifying the commit message to gnu-Add-r-weights
Related show

Checks

Context Check Description
cbaines/applying patch fail Apply failed

Commit Message

Lakshmi Prasannakumar Nov. 4, 2018, 4:27 p.m. UTC
Hi,

Pushing the cran.scm file to the latest branch.
Please find the attached file.

Thanks & Regards,
Lakshmi Prasannakumar
Bangalore


On Thu, Nov 1, 2018 at 11:44 PM Lakshmi Prasannakumar <
lakshmiprasannakumaran@gmail.com> wrote:

> Hi,
>
> Adding line breakers to the patch file. Please find the patch file
> attached to this mail.
>
> Thanks and Regards,
> Lakshmi Prasannakumar
> Bangalore
>
>
> On Thu, Nov 1, 2018 at 6:22 PM Lakshmi Prasannakumar <
> lakshmiprasannakumaran@gmail.com> wrote:
>
>> Hi,
>> Please find the attached patch file with this mail.
>> The changes made are to the cran.scm
>> * gnu/packages/cran.scm (r-weights): New variable.
>>
>> Thanks,
>> Lakshmi Prasannakumar
>> Bangalore
>>
>

Comments

Gábor Boskovits Nov. 4, 2018, 5:05 p.m. UTC | #1
Hello,

Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> ezt írta
(időpont: 2018. nov. 4., V, 17:27):
>
> Hi,
>
> Pushing the cran.scm file to the latest branch.
> Please find the attached file.
>

I got it, will have a look later.

> Thanks & Regards,
> Lakshmi Prasannakumar
> Bangalore
>
>
> On Thu, Nov 1, 2018 at 11:44 PM Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> wrote:
>>
>> Hi,
>>
>> Adding line breakers to the patch file. Please find the patch file attached to this mail.
>>
>> Thanks and Regards,
>> Lakshmi Prasannakumar
>> Bangalore
>>
>>
>> On Thu, Nov 1, 2018 at 6:22 PM Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> wrote:
>>>
>>> Hi,
>>> Please find the attached patch file with this mail.
>>> The changes made are to the cran.scm
>>> * gnu/packages/cran.scm (r-weights): New variable.
>>>
>>> Thanks,
>>> Lakshmi Prasannakumar
>>> Bangalore

Best regards,
g_bor
Gábor Boskovits Nov. 4, 2018, 9:12 p.m. UTC | #2
Hello Lakshmi,

There was a patch eariler in a better shape, this seems to be missing some
corrections you made earlier. Is that possible?

I intend to push a fixed version of the best patch we had so far
tomorrow, unless
I get a new version from you. WDYT?

Best regards,
g_bor
Gábor Boskovits <boskovits@gmail.com> ezt írta (időpont: 2018. nov.
4., V, 18:05):
>
> Hello,
>
> Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> ezt írta
> (időpont: 2018. nov. 4., V, 17:27):
> >
> > Hi,
> >
> > Pushing the cran.scm file to the latest branch.
> > Please find the attached file.
> >
>
> I got it, will have a look later.
>
> > Thanks & Regards,
> > Lakshmi Prasannakumar
> > Bangalore
> >
> >
> > On Thu, Nov 1, 2018 at 11:44 PM Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> wrote:
> >>
> >> Hi,
> >>
> >> Adding line breakers to the patch file. Please find the patch file attached to this mail.
> >>
> >> Thanks and Regards,
> >> Lakshmi Prasannakumar
> >> Bangalore
> >>
> >>
> >> On Thu, Nov 1, 2018 at 6:22 PM Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> wrote:
> >>>
> >>> Hi,
> >>> Please find the attached patch file with this mail.
> >>> The changes made are to the cran.scm
> >>> * gnu/packages/cran.scm (r-weights): New variable.
> >>>
> >>> Thanks,
> >>> Lakshmi Prasannakumar
> >>> Bangalore
>
> Best regards,
> g_bor
Lakshmi Prasannakumar Nov. 5, 2018, 8:41 p.m. UTC | #3
Hi Gábor,

As I pulled the latest updated version of cran.scm from git branch and
added the package definition to it, I missed to make the changes for
synopsis case. And the description went little off.
Comparing to the bug tracker, I followed the message lines and tried to
give a new message with the commit thinking it would resolve my build
issues, but I guess the format I followed was wrong again.
So, I have made the changes in cran.scm including all the corrections we
had done before and the commit message is made as the earlier version.
Sending in the updated patch file with this mail.
Kindly take a moment to review the same.

And as suggested, I have reworked on the timelines  where the videos can be
distributed.


Thanks and Regards,


Lakshmi Prasannakumar
Bangalore


On Mon, Nov 5, 2018 at 2:42 AM Gábor Boskovits <boskovits@gmail.com> wrote:

> Hello Lakshmi,
>
> There was a patch eariler in a better shape, this seems to be missing some
> corrections you made earlier. Is that possible?
>
> I intend to push a fixed version of the best patch we had so far
> tomorrow, unless
> I get a new version from you. WDYT?
>
> Best regards,
> g_bor
> Gábor Boskovits <boskovits@gmail.com> ezt írta (időpont: 2018. nov.
> 4., V, 18:05):
> >
> > Hello,
> >
> > Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> ezt írta
> > (időpont: 2018. nov. 4., V, 17:27):
> > >
> > > Hi,
> > >
> > > Pushing the cran.scm file to the latest branch.
> > > Please find the attached file.
> > >
> >
> > I got it, will have a look later.
> >
> > > Thanks & Regards,
> > > Lakshmi Prasannakumar
> > > Bangalore
> > >
> > >
> > > On Thu, Nov 1, 2018 at 11:44 PM Lakshmi Prasannakumar <
> lakshmiprasannakumaran@gmail.com> wrote:
> > >>
> > >> Hi,
> > >>
> > >> Adding line breakers to the patch file. Please find the patch file
> attached to this mail.
> > >>
> > >> Thanks and Regards,
> > >> Lakshmi Prasannakumar
> > >> Bangalore
> > >>
> > >>
> > >> On Thu, Nov 1, 2018 at 6:22 PM Lakshmi Prasannakumar <
> lakshmiprasannakumaran@gmail.com> wrote:
> > >>>
> > >>> Hi,
> > >>> Please find the attached patch file with this mail.
> > >>> The changes made are to the cran.scm
> > >>> * gnu/packages/cran.scm (r-weights): New variable.
> > >>>
> > >>> Thanks,
> > >>> Lakshmi Prasannakumar
> > >>> Bangalore
> >
> > Best regards,
> > g_bor
>
Gábor Boskovits Nov. 5, 2018, 9:43 p.m. UTC | #4
Thanks, I'll take a look.
Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> ezt írta
(időpont: 2018. nov. 5., H, 21:41):
>
> Hi Gábor,
>
> As I pulled the latest updated version of cran.scm from git branch and added the package definition to it, I missed to make the changes for synopsis case. And the description went little off.
> Comparing to the bug tracker, I followed the message lines and tried to give a new message with the commit thinking it would resolve my build issues, but I guess the format I followed was wrong again.
> So, I have made the changes in cran.scm including all the corrections we had done before and the commit message is made as the earlier version.
> Sending in the updated patch file with this mail.
> Kindly take a moment to review the same.
>
> And as suggested, I have reworked on the timelines  where the videos can be distributed.
>
>
> Thanks and Regards,
>
>
> Lakshmi Prasannakumar
> Bangalore
>
>
> On Mon, Nov 5, 2018 at 2:42 AM Gábor Boskovits <boskovits@gmail.com> wrote:
>>
>> Hello Lakshmi,
>>
>> There was a patch eariler in a better shape, this seems to be missing some
>> corrections you made earlier. Is that possible?
>>
>> I intend to push a fixed version of the best patch we had so far
>> tomorrow, unless
>> I get a new version from you. WDYT?
>>
>> Best regards,
>> g_bor
>> Gábor Boskovits <boskovits@gmail.com> ezt írta (időpont: 2018. nov.
>> 4., V, 18:05):
>> >
>> > Hello,
>> >
>> > Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> ezt írta
>> > (időpont: 2018. nov. 4., V, 17:27):
>> > >
>> > > Hi,
>> > >
>> > > Pushing the cran.scm file to the latest branch.
>> > > Please find the attached file.
>> > >
>> >
>> > I got it, will have a look later.
>> >
>> > > Thanks & Regards,
>> > > Lakshmi Prasannakumar
>> > > Bangalore
>> > >
>> > >
>> > > On Thu, Nov 1, 2018 at 11:44 PM Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> wrote:
>> > >>
>> > >> Hi,
>> > >>
>> > >> Adding line breakers to the patch file. Please find the patch file attached to this mail.
>> > >>
>> > >> Thanks and Regards,
>> > >> Lakshmi Prasannakumar
>> > >> Bangalore
>> > >>
>> > >>
>> > >> On Thu, Nov 1, 2018 at 6:22 PM Lakshmi Prasannakumar <lakshmiprasannakumaran@gmail.com> wrote:
>> > >>>
>> > >>> Hi,
>> > >>> Please find the attached patch file with this mail.
>> > >>> The changes made are to the cran.scm
>> > >>> * gnu/packages/cran.scm (r-weights): New variable.
>> > >>>
>> > >>> Thanks,
>> > >>> Lakshmi Prasannakumar
>> > >>> Bangalore
>> >
>> > Best regards,
>> > g_bor
Gábor Boskovits Nov. 5, 2018, 10:19 p.m. UTC | #5
Hello Lakshmi,

It would be nice if you could give this another shot, if not I will
commit it tomorrow with
some minor changes.

The commit message seems to be missing the second line (what has changed).

The license field still misses the prefix. See the mail from Björn earlier.

Could you squash your changes to a single commit?

(You can either do this on a throw-away branch with a git merge --squash, or
you can use git rebase -i, see this for more info
https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history.)

Best regards,
g_bor
Lakshmi Prasannakumar Nov. 8, 2018, 4:07 a.m. UTC | #6
Hi Gábor,

I am extremely sorry that , I did miss out this mail. I would like to know
, if there is anything more that I need to do on r-weights package
addition.
If not could you tell me how you fixed this to do the final commit ?

Thanks,

On Tue 6 Nov, 2018, 3:50 AM Gábor Boskovits <boskovits@gmail.com wrote:

> Hello Lakshmi,
>
> It would be nice if you could give this another shot, if not I will
> commit it tomorrow with
> some minor changes.
>
> The commit message seems to be missing the second line (what has changed).
>
> The license field still misses the prefix. See the mail from Björn earlier.
>
> Could you squash your changes to a single commit?
>
> (You can either do this on a throw-away branch with a git merge --squash,
> or
> you can use git rebase -i, see this for more info
>
> https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history
> .)
>
> Best regards,
> g_bor
>
Gábor Boskovits Nov. 8, 2018, 7:35 p.m. UTC | #7
I used the version where the most things were fixed, applied it to the
commit in Björn's message, created a branch, rebased on current master,
then fixed the commit message using amend, signed off and pushed. There is
no additional thing to do.

2018. nov. 8., Cs 5:07 dátummal Lakshmi Prasannakumar <
lakshmiprasannakumaran@gmail.com> ezt írta:

> Hi Gábor,
>
> I am extremely sorry that , I did miss out this mail. I would like to know
> , if there is anything more that I need to do on r-weights package
> addition.
> If not could you tell me how you fixed this to do the final commit ?
>
> Thanks,
>
> On Tue 6 Nov, 2018, 3:50 AM Gábor Boskovits <boskovits@gmail.com wrote:
>
>> Hello Lakshmi,
>>
>> It would be nice if you could give this another shot, if not I will
>> commit it tomorrow with
>> some minor changes.
>>
>> The commit message seems to be missing the second line (what has changed).
>>
>> The license field still misses the prefix. See the mail from Björn
>> earlier.
>>
>> Could you squash your changes to a single commit?
>>
>> (You can either do this on a throw-away branch with a git merge --squash,
>> or
>> you can use git rebase -i, see this for more info
>>
>> https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history
>> .)
>>
>> Best regards,
>> g_bor
>>
>
Lakshmi Prasannakumar Nov. 8, 2018, 8:36 p.m. UTC | #8
Thank You Gábor,

I was planning to look for dependencies to work on adding anaconda as a
package. Just got my system upgraded and will get back to you with a
roadmap to proceed with.
Or do you think I need to start working on something else?

Regards,
Lakshmi Prasannakumar
Bangalore


On Fri, Nov 9, 2018 at 1:05 AM Gábor Boskovits <boskovits@gmail.com> wrote:

> I used the version where the most things were fixed, applied it to the
> commit in Björn's message, created a branch, rebased on current master,
> then fixed the commit message using amend, signed off and pushed. There is
> no additional thing to do.
>
> 2018. nov. 8., Cs 5:07 dátummal Lakshmi Prasannakumar <
> lakshmiprasannakumaran@gmail.com> ezt írta:
>
>> Hi Gábor,
>>
>> I am extremely sorry that , I did miss out this mail. I would like to
>> know , if there is anything more that I need to do on r-weights package
>> addition.
>> If not could you tell me how you fixed this to do the final commit ?
>>
>> Thanks,
>>
>> On Tue 6 Nov, 2018, 3:50 AM Gábor Boskovits <boskovits@gmail.com wrote:
>>
>>> Hello Lakshmi,
>>>
>>> It would be nice if you could give this another shot, if not I will
>>> commit it tomorrow with
>>> some minor changes.
>>>
>>> The commit message seems to be missing the second line (what has
>>> changed).
>>>
>>> The license field still misses the prefix. See the mail from Björn
>>> earlier.
>>>
>>> Could you squash your changes to a single commit?
>>>
>>> (You can either do this on a throw-away branch with a git merge
>>> --squash, or
>>> you can use git rebase -i, see this for more info
>>>
>>> https://robots.thoughtbot.com/git-interactive-rebase-squash-amend-rewriting-history
>>> .)
>>>
>>> Best regards,
>>> g_bor
>>>
>>

Patch

From cb51b4f5199280e8af256fac12d32903d52857a3 Mon Sep 17 00:00:00 2001
From: lakshmi <lakshmiprasannakumaran@gmail.com>
Date: Sun, 4 Nov 2018 21:52:11 +0530
Subject: [PATCH 3/3] gnu:r-weights.:Add r-weights.

* gnu/packages/cran.scm (r-weight): New variable.

---
 gnu/packages/cran.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/cran.scm b/gnu/packages/cran.scm
index 28d0083..03969ca 100644
--- a/gnu/packages/cran.scm
+++ b/gnu/packages/cran.scm
@@ -7251,3 +7251,26 @@  using @dfn{penalized quasi-likelihood} (PQL) estimation (see Jaeger et
 al. (2016)).")
     (license license:gpl2)))
 >>>>>>> 30012b74088dccbb602e3592c61a5718fc5e5524
+
+(define-public r-weights
+  (package
+  (name "r-weights")
+  (version "1.0")
+  (source
+    (origin
+      (method url-fetch)
+      (uri (cran-uri "weights" version))
+      (sha256
+        (base32
+          "0186bfpkhxngrshac6bpg37alp6slwhwd43inrm8hqg0vhpfgc4c"))))
+  (build-system r-build-system)
+  (propagated-inputs
+    `(("r-gdata" ,r-gdata)
+      ("r-hmisc" ,r-hmisc)
+      ("r-mice" ,r-mice)))
+  (home-page
+    "http://cran.r-project.org/web/packages/weights")
+  (synopsis "Weighting and Weighted Statistics")
+  (description
+    "Provides a variety of functions for producing simple weighted statistics, such as weighted Pearson's correlations, partial correlations, Chi-Squared statistics, histograms, and t-tests. This package also now includes some software for quickly recoding survey data and plotting point estimates from interaction terms in regressions (and multiply imputed regressions). It must be noted that Weighted partial correlation calculations pulled to address a bug.")
+  (license gpl2+)))
-- 
2.9.3