[bug#36476] gnu: Add anonip.
diff mbox series

Message ID 20190702142003.14302-1-h.goebel@crazy-compilers.com
State New
Headers show
Series
  • [bug#36476] gnu: Add anonip.
Related show

Commit Message

Hartmut Goebel July 2, 2019, 2:20 p.m. UTC
* gnu/packages/web.scm (anonip): New variable.
---
 gnu/packages/web.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

Comments

Tobias Geerinckx-Rice July 2, 2019, 2:59 p.m. UTC | #1
Hartmut,

Thanks!  This should nicely replace some (probably buggy) ad-hoc 
code of mine :-)

Hartmut Goebel wrote:
> * gnu/packages/web.scm (anonip): New variable.
> ---
>  gnu/packages/web.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
> index 124cc93e68..386564206e 100644
> --- a/gnu/packages/web.scm
> +++ b/gnu/packages/web.scm
> @@ -33,6 +33,7 @@
>  ;;; Copyright © 2019 Nicolas Goaziou <mail@nicolasgoaziou.fr>
>  ;;; Copyright © 2019 Brendan Tildesley <mail@brendan.scot>
>  ;;; Copyright © 2019 Alex Griffin <a@ajgrf.com>
> +;;; Copyright © 2019 Hartmut Goebel 
> <h.goebel@crazy-compilers.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -6498,3 +6499,34 @@ update an existing mirrored site, and 
> resume interrupted downloads.
>  
>  HTTrack is fully configurable, and has an integrated help 
>  system.")
>      (license license:gpl3+)))
> +
> +(define-public anonip
> +  (package
> +    (name "anonip")
> +    (version "1.0.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (pypi-uri "anonip" version))
> +              (sha256
> +               (base32
> + 
> "0ckn9nnfhpdnz8b92q8pkysdqj6pdh71ckfqvfj0z01cq0hzbhd2"))))
> +    (build-system python-build-system)
> +    (inputs
> +     `(("python-3" ,python-3)))

I'm surprised: the python-build-system should take care of this. 
Does the package fail without it?  How?

> +    (home-page
> +     "https://github.com/DigitaleGesellschaft/Anonip")
> +    (synopsis
> +     "Anonymize IP-addresses in log-files")

IP addresses; log files.

I'm not a fan of the way the Pypi importer needlessly indents 
home-page and synopsis (both fit on one line just fine), but it's 
up to you.

> +    (description
> +     "Anonip masks the last bits of IPv4 and IPv6 addresses in 
> log-files.

As above, so below: ‘log files’ &c.

> +That way most of the relevant information is preserved, while 
> the IP-address
> +does not match a particular individuum anymore.
> +
> +Depending on your webserver software, the log entries may 
> directly get piped

Web server.  I'd drop ‘software’ and say ‘piped directly’.

> +to Anonip or read via a FIFO (named pipe).  Thus the unmasked 
> IP addresses

‘read from’.

> +will never be written to any file.
> +
> +It's also possible to rewrite existing log files.
> +
> +Anonip can also be uses as a Python module in your own Python 
> application.")
> +    (license license:bsd-3)))

Otherwise LGTM!

T G-R
Hartmut Goebel July 9, 2019, 11:24 a.m. UTC | #2
Tobias,

Thanks for your review. Committed as
582de58c69bd46385196e26434951e1e2d5f32f2

> Thanks!  This should nicely replace some (probably buggy) ad-hoc code
> of mine :-)

:-)

> +    (inputs
>> +     `(("python-3" ,python-3)))
>
> I'm surprised: the python-build-system should take care of this. Does
> the package fail without it?  How?

You are right, this is not required. I copied this without questioning
from some other python application (don't remember which one).


>> +Depending on your webserver software, the log entries may directly
>> get piped
>> +to Anonip or read via a FIFO (named pipe).  Thus the unmasked IP
>> addresses 
>
> ‘read from’.

I rephrased this into "Depending on your Web server, the log entries may
be piped to Anonip directly
or via a FIFO (named pipe)."  This emphases on piping

Patch
diff mbox series

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index 124cc93e68..386564206e 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -33,6 +33,7 @@ 
 ;;; Copyright © 2019 Nicolas Goaziou <mail@nicolasgoaziou.fr>
 ;;; Copyright © 2019 Brendan Tildesley <mail@brendan.scot>
 ;;; Copyright © 2019 Alex Griffin <a@ajgrf.com>
+;;; Copyright © 2019 Hartmut Goebel <h.goebel@crazy-compilers.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -6498,3 +6499,34 @@  update an existing mirrored site, and resume interrupted downloads.
 
 HTTrack is fully configurable, and has an integrated help system.")
     (license license:gpl3+)))
+
+(define-public anonip
+  (package
+    (name "anonip")
+    (version "1.0.0")
+    (source (origin
+              (method url-fetch)
+              (uri (pypi-uri "anonip" version))
+              (sha256
+               (base32
+                "0ckn9nnfhpdnz8b92q8pkysdqj6pdh71ckfqvfj0z01cq0hzbhd2"))))
+    (build-system python-build-system)
+    (inputs
+     `(("python-3" ,python-3)))
+    (home-page
+     "https://github.com/DigitaleGesellschaft/Anonip")
+    (synopsis
+     "Anonymize IP-addresses in log-files")
+    (description
+     "Anonip masks the last bits of IPv4 and IPv6 addresses in log-files.
+That way most of the relevant information is preserved, while the IP-address
+does not match a particular individuum anymore.
+
+Depending on your webserver software, the log entries may directly get piped
+to Anonip or read via a FIFO (named pipe).  Thus the unmasked IP addresses
+will never be written to any file.
+
+It's also possible to rewrite existing log files.
+
+Anonip can also be uses as a Python module in your own Python application.")
+    (license license:bsd-3)))