[bug#43292] gnu: emacs-org-contrib: Fix hash for version 20200907.
diff mbox series

Message ID 20200909113556.25569-1-zimon.toutoune@gmail.com
State New
Headers show
Series
  • [bug#43292] gnu: emacs-org-contrib: Fix hash for version 20200907.
Related show

Commit Message

zimoun Sept. 9, 2020, 11:35 a.m. UTC
* gnu/packages/emacs-xyz.scm (emacs-org-contrib): Fix hash.
---
 gnu/packages/emacs-xyz.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)


base-commit: e31289085d49618a29ea47af68d7a2746b44ee09

Comments

Simon,

On 2020-09-09 13:35, zimoun wrote:
> * gnu/packages/emacs-xyz.scm (emacs-org-contrib): Fix hash.

Thanks!  It's probably irrational, but in-place updates always tingle my 
paranoia.  What did they change?  Why?

I think it's good not to normalize them by at least briefly describing 
the upstream changes in the commit message.  ‘Fix’ is borderline 
misleading IMO.

If you don't have the time or access to the original, let me know.

Kind regards,

T G-R

Sent from a Web browser. Excuse or enjoy my brevity.
zimoun Sept. 9, 2020, 12:03 p.m. UTC | #2
On Wed, 9 Sep 2020 at 13:49, Tobias Geerinckx-Rice <me@tobias.gr> wrote:

> On 2020-09-09 13:35, zimoun wrote:
> > * gnu/packages/emacs-xyz.scm (emacs-org-contrib): Fix hash.
>
> Thanks!  It's probably irrational, but in-place updates always tingle my
> paranoia.  What did they change?  Why?

I do not understand either.
Maybe Nicolas could tell us more about this in-place update?
(I mean they seems involved in the Org-mode development)


> I think it's good not to normalize them by at least briefly describing
> the upstream changes in the commit message.  ‘Fix’ is borderline
> misleading IMO.

You mean something like that:

--8<---------------cut here---------------start------------->8---
 gnu: emacs-org-contrib: Update source hash.

 The previous tarball was modified in-place; see
????????

 * gnu/packages/emacs-xyz.scm (emacs-org-contrib)[source](sha256): Update.
--8<---------------cut here---------------end--------------->8---

(tweaked from harfbuzz replacement a8bb8fccd8)


> If you don't have the time or access to the original, let me know.

I have the time but not necessary the skills to access to the original.


> Sent from a Web browser. Excuse or enjoy my brevity.

I am doing both. :-)
> What did they change?  Why?

Irrelevant thanks to commit 057d584b981d9a3293be03ee863d40a61c8aae74.  
:-)

Closing,

T G-R

Sent from a Web browser. Excuse or enjoy my brevity.
zimoun Sept. 9, 2020, 12:56 p.m. UTC | #4
On Wed, 9 Sep 2020 at 14:33, Tobias Geerinckx-Rice <me@tobias.gr> wrote:

> Irrelevant thanks to commit 057d584b981d9a3293be03ee863d40a61c8aae74.
> :-)

Well, the version 20200908 is not referenced on the webpage:
https://orgmode.org/elpa/
So I am doubtful that commit 057d584b98 builds.

--8<---------------cut here---------------start------------->8---
guix time-machine --commit=057d584b981d9a3293be03ee863d40a61c8aae74 \
       -- build emacs-org-contrib
[...]

Starting download of
/gnu/store/bbc7d0dw6wl4vdhw9sfx35827f8qg42h-org-plus-contrib-20200908.tar
From https://orgmode.org/elpa/org-plus-contrib-20200908.tar...
download failed
"https://orgmode.org/elpa/org-plus-contrib-20200908.tar" 404 "Not
Found"

Starting download of
/gnu/store/bbc7d0dw6wl4vdhw9sfx35827f8qg42h-org-plus-contrib-20200908.tar
From https://ci.guix.gnu.org/file/org-plus-contrib-20200908.tar/sha256/1rgk3pwhsmbmwlncg60ahwrrkm1ks4xpwy2wzv9q7myl1aihjj54...
download failed
"https://ci.guix.gnu.org/file/org-plus-contrib-20200908.tar/sha256/1rgk3pwhsmbmwlncg60ahwrrkm1ks4xpwy2wzv9q7myl1aihjj54"
404 "Not Found"

Starting download of
/gnu/store/bbc7d0dw6wl4vdhw9sfx35827f8qg42h-org-plus-contrib-20200908.tar
From https://tarballs.nixos.org/sha256/1rgk3pwhsmbmwlncg60ahwrrkm1ks4xpwy2wzv9q7myl1aihjj54...
download failed
"https://tarballs.nixos.org/sha256/1rgk3pwhsmbmwlncg60ahwrrkm1ks4xpwy2wzv9q7myl1aihjj54"
404 "Not Found"

Starting download of
/gnu/store/bbc7d0dw6wl4vdhw9sfx35827f8qg42h-org-plus-contrib-20200908.tar
From https://archive.softwareheritage.org/api/1/content/sha256:a44809a30ad4d783d3fe5c787e3bd133d49933870a98c72ce575550df91df3e5/raw/...
download failed
"https://archive.softwareheritage.org/api/1/content/sha256:a44809a30ad4d783d3fe5c787e3bd133d49933870a98c72ce575550df91df3e5/raw/"
404 "Not Found"
failed to download
"/gnu/store/bbc7d0dw6wl4vdhw9sfx35827f8qg42h-org-plus-contrib-20200908.tar"
from "https://orgmode.org/elpa/org-plus-contrib-20200908.tar"
builder for `/gnu/store/01ncd7q8zd15mbckads5na0ys4a100ng-org-plus-contrib-20200908.tar.drv'
failed to produce output path
`/gnu/store/bbc7d0dw6wl4vdhw9sfx35827f8qg42h-org-plus-contrib-20200908.tar'
build of /gnu/store/01ncd7q8zd15mbckads5na0ys4a100ng-org-plus-contrib-20200908.tar.drv
failed
--8<---------------cut here---------------end--------------->8---
Nicolas Goaziou Sept. 9, 2020, 1:23 p.m. UTC | #5
Hello,

zimoun <zimon.toutoune@gmail.com> writes:

> On Wed, 9 Sep 2020 at 13:49, Tobias Geerinckx-Rice <me@tobias.gr> wrote:
>
>> On 2020-09-09 13:35, zimoun wrote:
>> > * gnu/packages/emacs-xyz.scm (emacs-org-contrib): Fix hash.
>>
>> Thanks!  It's probably irrational, but in-place updates always tingle my
>> paranoia.  What did they change?  Why?
>
> I do not understand either.
> Maybe Nicolas could tell us more about this in-place update?

Package is updated automatically either every Monday, provided there is
at least a pending commits since last update, or whenever a new Org is
released.

When new Org is released on a Monday, two updates happen the same day,
and therefore share the same version. It is unfortunate, but quite rare
in practice, and when the day is over, the source file cannot change
anymore.

Regards,
Nicolas,

On 2020-09-09 15:23, Nicolas Goaziou wrote:
> Package is updated automatically either every Monday, provided there is
> at least a pending commits since last update, or whenever a new Org is
> released.
> 
> When new Org is released on a Monday, two updates happen the same day,
> and therefore share the same version. It is unfortunate, but quite rare
> in practice, and when the day is over, the source file cannot change

Thanks for taking the time to explain.

It seems like the best ‘fix’ is for distributions (that don't like 
in-place updates) to simply wait a day after such a release.  Would that 
make sense?

Kind regards,

T G-R

Sent from a Web browser. Excuse or enjoy my brevity.
zimoun Sept. 9, 2020, 2 p.m. UTC | #7
Hi Nicolas,

On Wed, 9 Sep 2020 at 15:23, Nicolas Goaziou <mail@nicolasgoaziou.fr> wrote:

> Package is updated automatically either every Monday, provided there is
> at least a pending commits since last update, or whenever a new Org is
> released.
>
> When new Org is released on a Monday, two updates happen the same day,
> and therefore share the same version. It is unfortunate, but quite rare
> in practice, and when the day is over, the source file cannot change
> anymore.

Thank you for explaining.

All the best,
simon
Nicolas Goaziou Sept. 9, 2020, 2:05 p.m. UTC | #8
Tobias Geerinckx-Rice <me@tobias.gr> writes:

> Nicolas,
>
> On 2020-09-09 15:23, Nicolas Goaziou wrote:
>> Package is updated automatically either every Monday, provided there is
>> at least a pending commits since last update, or whenever a new Org is
>> released.
>>
>> When new Org is released on a Monday, two updates happen the same day,
>> and therefore share the same version. It is unfortunate, but quite rare
>> in practice, and when the day is over, the source file cannot change
>
> Thanks for taking the time to explain.
>
> It seems like the best ‘fix’ is for distributions (that don't like
> in-place updates) to simply wait a day after such a release.  Would
> that make sense?

Indeed. Never updating emacs-org or emacs-org-contrib on a Monday should
prevent this kind of issue.

Regards,

Patch
diff mbox series

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index f778838884..a7727c6dfd 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -9665,7 +9665,7 @@  programming and reproducible research.")
        (uri (string-append "https://orgmode.org/elpa/"
                            "org-plus-contrib-" version ".tar"))
        (sha256
-        (base32 "1f2471klf0v90irpp80413y4v6mhf9bwmrirdilk7qz2p1l6wf4z"))))
+        (base32 "1rgk3pwhsmbmwlncg60ahwrrkm1ks4xpwy2wzv9q7myl1aihjj54"))))
     (arguments
      `(#:modules ((guix build emacs-build-system)
                   (guix build utils)