[bug#34048] gnu: z3: Update to 4.8.4.

Message ID 87wonaaitq.fsf@aminb.org
State Accepted
Headers show
Series
  • [bug#34048] gnu: z3: Update to 4.8.4.
Related show

Checks

Context Check Description
cbaines/package builds pending In Cuirass
cbaines/applying patch fail Apply failed

Commit Message

Amin Bandali Jan. 11, 2019, 11:13 p.m. UTC

Comments

Leo Famulari Jan. 12, 2019, 11:30 p.m. UTC | #1
On Fri, Jan 11, 2019 at 06:13:53PM -0500, Amin Bandali wrote:
> From 2cd82564402e4363db581bde066766d779b6af1a Mon Sep 17 00:00:00 2001
> From: Amin Bandali <bandali@gnu.org>
> Date: Fri, 11 Jan 2019 18:08:42 -0500
> Subject: [PATCH] gnu: z3: Update to 4.8.4.
> 
> * gnu/packages/maths.scm (z3): Update to 4.8.4.

Thanks!

I tested this patch and found that arachne-pnr fails its test suite
after upgrading z3.

Can you take a look?
Amin Bandali Jan. 13, 2019, 3:57 a.m. UTC | #2
Hi Leo,

Thanks for the reply.

[...]

>
> I tested this patch and found that arachne-pnr fails its test suite
> after upgrading z3.
>
> Can you take a look?
>

Do you have test suite logs from before and after applying the patch?
Running ‘guix build arachne-pnr’ seems to fail for me on both ‘master’
and on my local ‘z3-4.8.4’ branch with my patch applied, so I’m not sure
if it’s my patch that’s broken its test suite.

Also, I’m a bit of Guix newbie, and I’m curious about if, and how, you
test all the packages, only those that depend on Z3, or if you happened
to stumble upon arachne-pnr’s failure.

Thanks,
amin
Efraim Flashner Jan. 13, 2019, 7:52 a.m. UTC | #3
On Sat, Jan 12, 2019 at 10:57:02PM -0500, Amin Bandali wrote:
> Hi Leo,
> 
> Thanks for the reply.
> 
> [...]
> 
> >
> > I tested this patch and found that arachne-pnr fails its test suite
> > after upgrading z3.
> >
> > Can you take a look?
> >
> 
> Do you have test suite logs from before and after applying the patch?
> Running ‘guix build arachne-pnr’ seems to fail for me on both ‘master’
> and on my local ‘z3-4.8.4’ branch with my patch applied, so I’m not sure
> if it’s my patch that’s broken its test suite.
> 
> Also, I’m a bit of Guix newbie, and I’m curious about if, and how, you
> test all the packages, only those that depend on Z3, or if you happened
> to stumble upon arachne-pnr’s failure.
> 

'guix refresh -l z3' shows:
Building the following 2 packages would ensure 3 dependent packages are rebuilt: arachne-pnr@0.0-1-52e69ed20 cubicle@1.1.2

so in theory it's inexpensive to test the packages. Based on
arachne-pnr's version number, I'd check if there's a later commit that
doesn't fail the test suite.

Patch

From 2cd82564402e4363db581bde066766d779b6af1a Mon Sep 17 00:00:00 2001
From: Amin Bandali <bandali@gnu.org>
Date: Fri, 11 Jan 2019 18:08:42 -0500
Subject: [PATCH] gnu: z3: Update to 4.8.4.

* gnu/packages/maths.scm (z3): Update to 4.8.4.
---
 gnu/packages/maths.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 4138c7a3b..2c5108388 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -3937,7 +3937,7 @@  as equations, scalars, vectors, and matrices.")
 (define-public z3
   (package
     (name "z3")
-    (version "4.8.3")
+    (version "4.8.4")
     (home-page "https://github.com/Z3Prover/z3")
     (source (origin
               (method git-fetch)
@@ -3946,7 +3946,7 @@  as equations, scalars, vectors, and matrices.")
               (file-name (git-file-name name version))
               (sha256
                (base32
-                "0p5gdmhd32x6zwmx7j5cgwh4jyfxa9yapym95nlmyfaqzak92qar"))))
+                "014igqm5vwswz0yhz0cdxsj3a6dh7i79hvhgc3jmmmz3z0xm1gyn"))))
     (build-system gnu-build-system)
     (arguments
      `(#:phases
-- 
2.20.1