diff mbox series

[bug#44722] gnu: web: add uriparser

Message ID 61GMcRudrqz0j9_UV7ajK_jffCV3On0vlQzjLrU6Ly3fS-n5F9aQvtH41aL2clXwcIpH0xi3B8iEL9iiCxjFvv_fUMet1_J95kMaYn0hnQ4=@protonmail.com
State New
Headers show
Series [bug#44722] gnu: web: add uriparser | expand

Checks

Context Check Description
cbaines/applying patch fail View Laminar job
cbaines/issue success View issue

Commit Message

lspangler Nov. 18, 2020, 1:48 p.m. UTC
From 1141a871635f048147faf022a9b649d6f8553080 Mon Sep 17 00:00:00 2001
From: Lane Spangler <lspangler@protonmail.com>
Date: Tue, 17 Nov 2020 17:50:06 +0100
Subject: [PATCH] gnu: web: add uriparser

---
gnu/packages/web.scm | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)

--
2.29.2

Comments

Ludovic Courtès Nov. 26, 2020, 10:19 p.m. UTC | #1
Hello Lane,

lspangler <lspangler@protonmail.com> skribis:

> From 1141a871635f048147faf022a9b649d6f8553080 Mon Sep 17 00:00:00 2001
> From: Lane Spangler <lspangler@protonmail.com>
> Date: Tue, 17 Nov 2020 17:50:06 +0100
> Subject: [PATCH] gnu: web: add uriparser
>
> ---
> gnu/packages/web.scm | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)

It looks like the patch was mangled on the way.  Could you send it
as an attachment or using ‘git send-email’?

Some minor issues below:

> +(define-public uriparser
> +  (let [(commit "9e1fba08c231f1990fdee13545ab3a0ac804bd3c")
> +        (revision "1")]

Normally we pick upstream releases.  If there’s a good reason to pick
this commit rather than the latest release, could you please add a
comment above it explaining why?

Nitpick: Please use only regular parentheses, for consistency.

> +      (synopsis "Strictly RFC 3986 compliant URI parsing and handling
> + library written in C89")

What about making it shorter: “RFC 3986 compliant URI parsing and
handling library”?

> +      (description "uriparser is a strictly RFC 3986 compliant URI
> + parsing and handling library written in C89 (\"ANSI C\").
> +uriparser is cross-platform, fast, and supports Unicode")

I think you can omit “cross-platform” since that’s not relevant from a
Guix user standpoint.  Please add a period at the end of the sentence.

Could you send an updated patch?

Thanks!

Ludo’.
diff mbox series

Patch

diff --git a/gnu/packages/web.scm b/gnu/packages/web.scm
index edb7bd5da1..d79877c78a 100644
--- a/gnu/packages/web.scm
+++ b/gnu/packages/web.scm
@@ -111,6 +111,7 @@ 
#:use-module (gnu packages gnupg)
#:use-module (gnu packages golang)
#:use-module (gnu packages gperf)
+ #:use-module (gnu packages graphviz)
#:use-module (gnu packages gtk)
#:use-module (gnu packages guile)
#:use-module (gnu packages guile-xyz)
@@ -7747,3 +7748,30 @@  solution for any project's interface needs:
(description "gmnisrv is a simple Gemini protocol server written in C.")
(license (list license:gpl3+
license:bsd-3))))) ;; for ini.c and ini.h
+
+(define-public uriparser
+ (let [(commit "9e1fba08c231f1990fdee13545ab3a0ac804bd3c")
+ (revision "1")]
+ (package
+ (name "uriparser")
+ (version (git-version "0.9.4" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/uriparser/uriparser")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "13spkcsi8p5732bviy41y8dv5aw4vg83gqdclbsb9ayfbr2ybjx0"))))
+ (build-system cmake-build-system)
+ (native-inputs `(("gtest" ,googletest)
+ ("doxygen" ,doxygen)
+ ("graphviz" ,graphviz)))
+ (synopsis "Strictly RFC 3986 compliant URI parsing and handling
+ library written in C89")
+ (description "uriparser is a strictly RFC 3986 compliant URI
+ parsing and handling library written in C89 (\"ANSI C\").
+uriparser is cross-platform, fast, and supports Unicode")
+ (home-page "https://uriparser.github.io/")
+ (license license:bsd-3))))