diff mbox series

[bug#43967] Add python2-parallel

Message ID 86eem32tju.fsf@gmail.com
State Accepted
Headers show
Series [bug#43967] Add python2-parallel | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch fail View Laminar job

Commit Message

BonfaceKilz Oct. 12, 2020, 6:22 p.m. UTC
Hi all.

Find attached a patch that adds
python2-parallel. Any feedback is welcome.

Comments

Efraim Flashner Oct. 13, 2020, 7:13 a.m. UTC | #1
On Mon, Oct 12, 2020 at 09:22:29PM +0300, Bonface M. K. wrote:
> Hi all.
> 
> Find attached a patch that adds
> python2-parallel. Any feedback is welcome.
> 
> -- 
> Bonface M. K. (https://www.bonfacemunyoki.com)
> Chief Emacs Mchochezi / Twitter: @BonfaceKilz
> GPG key = D4F09EB110177E03C28E2FE1F5BBAE1E0392253F

> From 23d1ac31023d9c3bc1d35fba868d203a2d1d22ea Mon Sep 17 00:00:00 2001
> From: BonfaceKilz <bonfacemunyoki@gmail.com>
> Date: Mon, 12 Oct 2020 21:04:01 +0300
> Subject: [PATCH] gnu: Add python2-parallel.
> 
> * gnu/packages/python-xyz (python2-parallel): New package.
> ---
>  gnu/packages/python-xyz.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> index 56c7bb84ab..e149328e35 100644
> --- a/gnu/packages/python-xyz.scm
> +++ b/gnu/packages/python-xyz.scm
> @@ -85,6 +85,7 @@
>  ;;; Copyright © 2020 Guy Fleury Iteriteka <gfleury@disroot.org>
>  ;;; Copyright © 2020 Hendursaga <hendursaga@yahoo.com>
>  ;;; Copyright © 2020 Malte Frank Gerdes <malte.f.gerdes@gmail.com>
> +;;; Copyright © 2020 Kilyungi Bonface Munyoki <bonfacemunyoki@gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -22218,3 +22219,34 @@ NestedText is both simple and natural.  Only a small number of concepts and rule
>  be kept in mind when creating it.  It is easily created, modified, or viewed with
>  a text editor and easily understood and used by both programmers and non-programmers.")
>      (license license:expat))) ; MIT license
> +
> +(define-public python2-parallel
> +  (package
> +    (name "python2-parallel")
> +    (version "1.6.6")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://www.parallelpython.com/downloads/pp/pp-"
> +             version ".zip"))

There is a tar.gz and a tar.bz2 version also available. Any reason in
particular for the zip version?

> +       (sha256
> +        (base32
> +         "15fhpr6kv4j45f9i55mwi5smzskm0pfwwagya7wq3wwlfaz9pj5c"))))
> +    (native-inputs
> +     `(("unzip" ,unzip)))
> +    (build-system python-build-system)
> +    (arguments
> +     `(#:python ,python-2
> +       ; Package has no tests
> +       #:tests? #f))
> +    (home-page "https://www.parallelpython.com")
> +    (synopsis "Parallel and distributed programming for Python")
> +    (description "Parallel Python module (PP) provides an easy and efficient
> +way to create parallel-enabled applications for SMP computers and clusters.
> +PP module features cross-platform portability and dynamic load balancing.
> +Thus application written with PP will parallelize efficiently even on
> +heterogeneous and multi-platform clusters (including clusters running other
> +application with variable CPU loads).  Visit http://www.parallelpython.com for
> +further information.")

I think we can drop the "visit the webpage" line.

> +    (license license:bsd-3)))
> -- 
> 2.28.0
> 

I haven't been able to find a back catalog of their releases and ended
up dropping back from 1.6.1 to 1.5.7 since there's a copy stored on IPFS
I can add to the store when needed.
BonfaceKilz Oct. 13, 2020, 8:08 a.m. UTC | #2
Efraim Flashner <efraim@flashner.co.il> writes:

> On Mon, Oct 12, 2020 at 09:22:29PM +0300, Bonface M. K. wrote:
>> Hi all.
>> 
>> Find attached a patch that adds
>> python2-parallel. Any feedback is welcome.
>> 
>> -- 
>> Bonface M. K. (https://www.bonfacemunyoki.com)
>> Chief Emacs Mchochezi / Twitter: @BonfaceKilz
>> GPG key = D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
>
>> From 23d1ac31023d9c3bc1d35fba868d203a2d1d22ea Mon Sep 17 00:00:00 2001
>> From: BonfaceKilz <bonfacemunyoki@gmail.com>
>> Date: Mon, 12 Oct 2020 21:04:01 +0300
>> Subject: [PATCH] gnu: Add python2-parallel.
>> 
>> * gnu/packages/python-xyz (python2-parallel): New package.
>> ---
>>  gnu/packages/python-xyz.scm | 32 ++++++++++++++++++++++++++++++++
>>  1 file changed, 32 insertions(+)
>> 
>> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
>> index 56c7bb84ab..e149328e35 100644
>> --- a/gnu/packages/python-xyz.scm
>> +++ b/gnu/packages/python-xyz.scm
>> @@ -85,6 +85,7 @@
>>  ;;; Copyright © 2020 Guy Fleury Iteriteka <gfleury@disroot.org>
>>  ;;; Copyright © 2020 Hendursaga <hendursaga@yahoo.com>
>>  ;;; Copyright © 2020 Malte Frank Gerdes <malte.f.gerdes@gmail.com>
>> +;;; Copyright © 2020 Kilyungi Bonface Munyoki <bonfacemunyoki@gmail.com>
>>  ;;;
>>  ;;; This file is part of GNU Guix.
>>  ;;;
>> @@ -22218,3 +22219,34 @@ NestedText is both simple and natural.  Only a small number of concepts and rule
>>  be kept in mind when creating it.  It is easily created, modified, or viewed with
>>  a text editor and easily understood and used by both programmers and non-programmers.")
>>      (license license:expat))) ; MIT license
>> +
>> +(define-public python2-parallel
>> +  (package
>> +    (name "python2-parallel")
>> +    (version "1.6.6")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "https://www.parallelpython.com/downloads/pp/pp-"
>> +             version ".zip"))
>
> There is a tar.gz and a tar.bz2 version also available. Any reason in
> particular for the zip version?
>

I don't have a good reason. I wanted to upstream
this package from gn2- and unzip was used
there. Is there a preference to use tar.gz or
tar.bz2 (as oppossed to zip)? I'm guessing better
compression? I can resubmit this with the tar.gz.

>> +       (sha256
>> +        (base32
>> +         "15fhpr6kv4j45f9i55mwi5smzskm0pfwwagya7wq3wwlfaz9pj5c"))))
>> +    (native-inputs
>> +     `(("unzip" ,unzip)))
>> +    (build-system python-build-system)
>> +    (arguments
>> +     `(#:python ,python-2
>> +       ; Package has no tests
>> +       #:tests? #f))
>> +    (home-page "https://www.parallelpython.com")
>> +    (synopsis "Parallel and distributed programming for Python")
>> +    (description "Parallel Python module (PP) provides an easy and efficient
>> +way to create parallel-enabled applications for SMP computers and clusters.
>> +PP module features cross-platform portability and dynamic load balancing.
>> +Thus application written with PP will parallelize efficiently even on
>> +heterogeneous and multi-platform clusters (including clusters running other
>> +application with variable CPU loads).  Visit http://www.parallelpython.com for
>> +further information.")
>
> I think we can drop the "visit the webpage" line.
>

Sure!

>> +    (license license:bsd-3)))
>> -- 
>> 2.28.0
>> 
>
> I haven't been able to find a back catalog of their releases and ended
> up dropping back from 1.6.1 to 1.5.7 since there's a copy stored on IPFS
> I can add to the store when needed.

Ah yes. This would be useful. And I'm guessing
that would go to guix-past right?
Efraim Flashner Oct. 13, 2020, 8:19 a.m. UTC | #3
On Tue, Oct 13, 2020 at 11:08:19AM +0300, Bonface M. K. wrote:
> Efraim Flashner <efraim@flashner.co.il> writes:
> 
> > On Mon, Oct 12, 2020 at 09:22:29PM +0300, Bonface M. K. wrote:
> >> Hi all.
> >> 
> >> Find attached a patch that adds
> >> python2-parallel. Any feedback is welcome.
> >> 
> >> -- 
> >> Bonface M. K. (https://www.bonfacemunyoki.com)
> >> Chief Emacs Mchochezi / Twitter: @BonfaceKilz
> >> GPG key = D4F09EB110177E03C28E2FE1F5BBAE1E0392253F
> >
> >> From 23d1ac31023d9c3bc1d35fba868d203a2d1d22ea Mon Sep 17 00:00:00 2001
> >> From: BonfaceKilz <bonfacemunyoki@gmail.com>
> >> Date: Mon, 12 Oct 2020 21:04:01 +0300
> >> Subject: [PATCH] gnu: Add python2-parallel.
> >> 
> >> * gnu/packages/python-xyz (python2-parallel): New package.
> >> ---
> >>  gnu/packages/python-xyz.scm | 32 ++++++++++++++++++++++++++++++++
> >>  1 file changed, 32 insertions(+)
> >> 
> >> diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
> >> index 56c7bb84ab..e149328e35 100644
> >> --- a/gnu/packages/python-xyz.scm
> >> +++ b/gnu/packages/python-xyz.scm
> >> @@ -85,6 +85,7 @@
> >>  ;;; Copyright © 2020 Guy Fleury Iteriteka <gfleury@disroot.org>
> >>  ;;; Copyright © 2020 Hendursaga <hendursaga@yahoo.com>
> >>  ;;; Copyright © 2020 Malte Frank Gerdes <malte.f.gerdes@gmail.com>
> >> +;;; Copyright © 2020 Kilyungi Bonface Munyoki <bonfacemunyoki@gmail.com>
> >>  ;;;
> >>  ;;; This file is part of GNU Guix.
> >>  ;;;
> >> @@ -22218,3 +22219,34 @@ NestedText is both simple and natural.  Only a small number of concepts and rule
> >>  be kept in mind when creating it.  It is easily created, modified, or viewed with
> >>  a text editor and easily understood and used by both programmers and non-programmers.")
> >>      (license license:expat))) ; MIT license
> >> +
> >> +(define-public python2-parallel
> >> +  (package
> >> +    (name "python2-parallel")
> >> +    (version "1.6.6")
> >> +    (source
> >> +     (origin
> >> +       (method url-fetch)
> >> +       (uri (string-append
> >> +             "https://www.parallelpython.com/downloads/pp/pp-"
> >> +             version ".zip"))
> >
> > There is a tar.gz and a tar.bz2 version also available. Any reason in
> > particular for the zip version?
> >
> 
> I don't have a good reason. I wanted to upstream
> this package from gn2- and unzip was used
> there. Is there a preference to use tar.gz or
> tar.bz2 (as oppossed to zip)? I'm guessing better
> compression? I can resubmit this with the tar.gz.
> 

The decompressors (there's got to be a better word) for gzip and bzip2
are already in the build environment so it means we don't need to pull
in unzip also.

> >> +       (sha256
> >> +        (base32
> >> +         "15fhpr6kv4j45f9i55mwi5smzskm0pfwwagya7wq3wwlfaz9pj5c"))))
> >> +    (native-inputs
> >> +     `(("unzip" ,unzip)))
> >> +    (build-system python-build-system)
> >> +    (arguments
> >> +     `(#:python ,python-2

Also, does it build with python3? I think we're trying to not add too
many more python2-only packages now that python2 is end of life.

> >> +       ; Package has no tests
> >> +       #:tests? #f))
> >> +    (home-page "https://www.parallelpython.com")
> >> +    (synopsis "Parallel and distributed programming for Python")
> >> +    (description "Parallel Python module (PP) provides an easy and efficient
> >> +way to create parallel-enabled applications for SMP computers and clusters.
> >> +PP module features cross-platform portability and dynamic load balancing.
> >> +Thus application written with PP will parallelize efficiently even on
> >> +heterogeneous and multi-platform clusters (including clusters running other
> >> +application with variable CPU loads).  Visit http://www.parallelpython.com for
> >> +further information.")
> >
> > I think we can drop the "visit the webpage" line.
> >
> 
> Sure!
> 
> >> +    (license license:bsd-3)))
> >> -- 
> >> 2.28.0
> >> 
> >
> > I haven't been able to find a back catalog of their releases and ended
> > up dropping back from 1.6.1 to 1.5.7 since there's a copy stored on IPFS
> > I can add to the store when needed.
> 
> Ah yes. This would be useful. And I'm guessing
> that would go to guix-past right?
> 

The problem Really is that once they update the package the source for
the current package disappears.
BonfaceKilz Oct. 18, 2020, 10:29 a.m. UTC | #4
Hi guix! This patch strips out the python2 package definition and /just/ adds
the python3 package in addition to fixing some grammatical errors in the
package description.

BonfaceKilz (1):
  * gnu/packages/python-xyz (python-parallel): New package.

 gnu/packages/python-xyz.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)
diff mbox series

Patch

From 23d1ac31023d9c3bc1d35fba868d203a2d1d22ea Mon Sep 17 00:00:00 2001
From: BonfaceKilz <bonfacemunyoki@gmail.com>
Date: Mon, 12 Oct 2020 21:04:01 +0300
Subject: [PATCH] gnu: Add python2-parallel.

* gnu/packages/python-xyz (python2-parallel): New package.
---
 gnu/packages/python-xyz.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 56c7bb84ab..e149328e35 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -85,6 +85,7 @@ 
 ;;; Copyright © 2020 Guy Fleury Iteriteka <gfleury@disroot.org>
 ;;; Copyright © 2020 Hendursaga <hendursaga@yahoo.com>
 ;;; Copyright © 2020 Malte Frank Gerdes <malte.f.gerdes@gmail.com>
+;;; Copyright © 2020 Kilyungi Bonface Munyoki <bonfacemunyoki@gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -22218,3 +22219,34 @@  NestedText is both simple and natural.  Only a small number of concepts and rule
 be kept in mind when creating it.  It is easily created, modified, or viewed with
 a text editor and easily understood and used by both programmers and non-programmers.")
     (license license:expat))) ; MIT license
+
+(define-public python2-parallel
+  (package
+    (name "python2-parallel")
+    (version "1.6.6")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://www.parallelpython.com/downloads/pp/pp-"
+             version ".zip"))
+       (sha256
+        (base32
+         "15fhpr6kv4j45f9i55mwi5smzskm0pfwwagya7wq3wwlfaz9pj5c"))))
+    (native-inputs
+     `(("unzip" ,unzip)))
+    (build-system python-build-system)
+    (arguments
+     `(#:python ,python-2
+       ; Package has no tests
+       #:tests? #f))
+    (home-page "https://www.parallelpython.com")
+    (synopsis "Parallel and distributed programming for Python")
+    (description "Parallel Python module (PP) provides an easy and efficient
+way to create parallel-enabled applications for SMP computers and clusters.
+PP module features cross-platform portability and dynamic load balancing.
+Thus application written with PP will parallelize efficiently even on
+heterogeneous and multi-platform clusters (including clusters running other
+application with variable CPU loads).  Visit http://www.parallelpython.com for
+further information.")
+    (license license:bsd-3)))
-- 
2.28.0