diff mbox series

[bug#43910] gnu: emacs-modus-vivendi-theme: Update to 0.13.0.

Message ID DM5PR1001MB210520D021E476DE3ACB101BC5090@DM5PR1001MB2105.namprd10.prod.outlook.com
State New
Headers show
Series [bug#43910] gnu: emacs-modus-vivendi-theme: Update to 0.13.0. | expand

Checks

Context Check Description
cbaines/comparison success View comparision
cbaines/git branch success View Git branch
cbaines/applying patch success View Laminar job

Commit Message

Morgan Smith Oct. 10, 2020, 4 p.m. UTC
From: Morgan Smith <Morgan.J.Smith@outlook.com>

* gnu/packages/emacs-xyz.scm (emacs-modus-vivendi-theme): Update to 0.13.0.
[source]: Use git instead of elpa, as elpa is out of date
[arguments]: Add phase to remove modus-operandi-theme.el
---
 gnu/packages/emacs-xyz.scm | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

Comments

Nicolas Goaziou Oct. 11, 2020, 4:25 p.m. UTC | #1
Hello,

Morgan.J.Smith@outlook.com writes:

> * gnu/packages/emacs-xyz.scm (emacs-modus-vivendi-theme): Update to 0.13.0.
> [source]: Use git instead of elpa, as elpa is out of date
> [arguments]: Add phase to remove modus-operandi-theme.el

Thank you.

However I suggest we stick to GNU ELPA repository, since it makes the
package much easier to update. Also, GNU ELPA will eventually catch up
with the new version.

WDYT?

Regards,
Morgan Smith Oct. 11, 2020, 4:33 p.m. UTC | #2
I was thinking the author likely stopped updating elpa once his package
made it into mainline emacs (but not in time for 27.1). I guess I'll
reach out and let him know he should keep updating it for a bit.

Also I remembered someone telling me to not use elpa. Upon checking the
history, you warned me about melpa, not elpa.

Cheers!
diff mbox series

Patch

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 44aaaa0541..f1ebdd90ff 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -22685,15 +22685,25 @@  standard.  This is the highest standard of its kind.")
 (define-public emacs-modus-vivendi-theme
   (package
     (name "emacs-modus-vivendi-theme")
-    (version "0.12.0")
+    (version "0.13.0")
     (source
      (origin
-       (method url-fetch)
-       (uri (string-append "https://elpa.gnu.org/packages/"
-                           "modus-vivendi-theme-" version ".el"))
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://gitlab.com/protesilaos/modus-themes")
+             (commit version)))
+       (file-name (git-file-name name version))
        (sha256
-        (base32 "01f6z5xjnmki1k9m83jwva42lxidb31pdpwm4wpxjzxqmb96picn"))))
+        (base32
+         "0i6n3pzrmlgabsijy6z0hhs71q7g99yagwr2m33lr30skqc9rvdn"))))
     (build-system emacs-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'remove-other-theme
+           (lambda _
+             (delete-file "modus-operandi-theme.el")
+             #t)))))
     (home-page "https://gitlab.com/protesilaos/modus-themes")
     (synopsis "Accessible dark theme (WCAG AAA)")
     (description